Skip to content

Fix: replace data variable with trigger variable in EAPOL_KEY.guess_key_number #4703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 21, 2025

Conversation

birdiecode
Copy link
Contributor

There are two variables in the code: one is responsible for the presence or absence of data (trigger), and the other contains the data itself. Instead of using a trigger, the function uses a variable with data, which can lead to incorrect program behavior.

gpotter2
gpotter2 previously approved these changes Mar 31, 2025
Copy link
Member

@gpotter2 gpotter2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR ! LGTM.

@birdiecode
Copy link
Contributor Author

Screenshot_20250331_105937
Screenshot_20250331_110602
For clarity, two screenshots are attached: one showing the function execution result and the other displaying the variable states during debugging inside the function.

@gpotter2 gpotter2 merged commit d876346 into secdev:master Apr 21, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants